[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969863#comment-13969863
]
Jerry He commented on HBASE-10948:
----------------------------------
Anyone has time to look at this JIRA?
The code change is small. The impact looks big. But it is contained.
Here are all the calls to FSUtils.getFilePermissions() after a search:
{code}
getFilePermissions(FileSystem, Configuration, String) : FsPermission -
org.apache.hadoop.hbase.util.FSUtils
createOutputStream(Configuration, FileSystem, Path, InetSocketAddress[]) :
FSDataOutputStream -
org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter
testDeleteAndExists() :
void - org.apache.hadoop.hbase.util.TestFSUtils
testPermMask() :
void - org.apache.hadoop.hbase.util.TestFSUtils (3 matches)
writeRegionInfoFileContent(Configuration, FileSystem, Path, byte[]) :
void - org.apache.hadoop.hbase.regionserver.HRegionFileSystem
writeSnapshotInfo(SnapshotDescription, Path, FileSystem) :
void - org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils
{code}
This change does not affect the WALs files because it does not have this
problem.
> Fix hbase table file 'x' mode
> -----------------------------
>
> Key: HBASE-10948
> URL: https://issues.apache.org/jira/browse/HBASE-10948
> Project: HBase
> Issue Type: Bug
> Components: Filesystem Integration
> Affects Versions: 0.96.2, 0.98.1
> Reporter: Jerry He
> Assignee: Jerry He
> Fix For: 0.99.0
>
> Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
>
>
> The hbase table files currently all have 'x' mode in there:
> {code}
> $hadoop fs -ls -R /hbase/data/default/TestTable/
> drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
> /hbase/data/default/TestTable/.tabledesc
> -rw-r--r-- 1 hbase biadmin 313 2014-04-08 20:53
> /hbase/data/default/TestTable/.tabledesc/.tableinfo.0000000001
> drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
> /hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
> -rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
> /hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
> drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
> /hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
> -rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
> /hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
> -rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
> /hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
> drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
> /hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
> -rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
> /hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
> drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
> /hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
> -rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
> /hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
> -rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
> /hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
> {code}
> If the user does not specify 'hbase.data.umask', we use the fs default:
> FsPermission.getDefault()
> Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
