[ 
https://issues.apache.org/jira/browse/HBASE-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969928#comment-13969928
 ] 

Lars Hofhansl commented on HBASE-10988:
---------------------------------------

I'd suggest something like this in all branches:
{code}
    // wait up to 10s for the 
    for (int i=0; i<100 && (thriftServer.serverRunner == null || 
thriftServer.serverRunner.tserver == null); i++) {
      Thread.sleep(100);
    }
{code}


> Properly wait for server in TestThriftServerCmdLine
> ---------------------------------------------------
>
>                 Key: HBASE-10988
>                 URL: https://issues.apache.org/jira/browse/HBASE-10988
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3
>
>
> In 0.94 I find:
> {{Threads.sleepWithoutInterrupt(2000)}}
> In trunk I see:
> {code}
>      while ( thriftServer.serverRunner == null || 
> thriftServer.serverRunner.tserver == null ){
>        Thread.sleep(1);
>      }
> {code}
> Both aren't good.
> The 0.94 version will fail if the server does not come up within 2s. The 
> trunk version (1) might wait forever and cause a long timeout for the test 
> and (2) wait quite busily with only 1ms of sleeping.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to