[
https://issues.apache.org/jira/browse/HBASE-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079181#comment-13079181
]
[email protected] commented on HBASE-4160:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1285/#review1287
-----------------------------------------------------------
Change looks good.
Have you tried close_region command ?
- Ted
On 2011-08-04 01:54:09, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1285/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-04 01:54:09)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Ted Yu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Similar to HBASE-4115, this entails a conversion of
org.apache.hadoop.hbase.utils.Bytes.toBytes to a to_java_bytes call in the
'move' and 'online' call.
bq.
bq. Root cause is due to how Bytes.toBytes assumes UTF-8 whild ruby's
to_java_bytes assumes straight bytes.
bq.
bq.
bq. This addresses bug hbase-4160.
bq. https://issues.apache.org/jira/browse/hbase-4160
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/ruby/hbase/admin.rb 1d72424
bq.
bq. Diff: https://reviews.apache.org/r/1285/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. For move:
bq. in shell: issue
bq. move "\x7f\x80","\x79\x80"
bq. in clipse set breakpoint on HMaster.move(...); args are byte arrays [127,
-128], [127, -128]
bq.
bq. I can't figure out how to trigger the 'online' call from the shell.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> HBase shell move and online may be unusable if region name or server includes
> binary-encoded data
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-4160
> URL: https://issues.apache.org/jira/browse/HBASE-4160
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.3
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Priority: Minor
> Attachments:
> 0001-HBASE-4160-HBase-shell-move-and-online-may-be-unusab.patch
>
>
> Similar to HBASE-4115, this entails a conversion of
> org.apache.hadoop.hbase.utils.Bytes.toBytes to a to_java_bytes call in the
> 'move' and 'online' call.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira