[
https://issues.apache.org/jira/browse/HBASE-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972100#comment-13972100
]
Varun Sharma commented on HBASE-11007:
--------------------------------------
I agree on the backward compatibility issue. How about at least adding a test,
as part of this issue, on this property which exercises the code path and makes
sure that it only touches Data Blocks ? I found several tests on
CACHE_DATA_ON_WRITE etc. but none for this option ? Did I miss the unit test by
any chance ?
Thanks !
Varun
> BLOCKCACHE in schema descriptor seems not aptly named
> -----------------------------------------------------
>
> Key: HBASE-11007
> URL: https://issues.apache.org/jira/browse/HBASE-11007
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.18
> Reporter: Varun Sharma
> Assignee: Varun Sharma
> Priority: Minor
>
> Hi,
> It seems that setting BLOCKCACHE key to false will disable the Data blocks
> from being cached but will continue to cache bloom and index blocks. This
> same property seems to be called cacheDataOnRead inside CacheConfig.
> Should this be called CACHE_DATA_ON_READ instead of BLOCKCACHE similar to the
> other CACHE_DATA_ON_WRITE/CACHE_INDEX_ON_WRITE. We got quite confused and
> ended up adding our own property CACHE_DATA_ON_READ - we also added some unit
> tests for the same.
> What do folks think about this ?
> Thanks
> Varun
--
This message was sent by Atlassian JIRA
(v6.2#6252)
