[
https://issues.apache.org/jira/browse/HBASE-11012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973228#comment-13973228
]
Nick Dimiduk commented on HBASE-11012:
--------------------------------------
Looks good to me. On commit, please add a javadoc to the method pointing out
that it closes the provided InputStream -- help out everyone's future selves.
Thanks.
> InputStream is not properly closed in two methods of JarFinder
> --------------------------------------------------------------
>
> Key: HBASE-11012
> URL: https://issues.apache.org/jira/browse/HBASE-11012
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Trivial
> Attachments: 11012-v2.txt
>
>
> JarFinder#jarDir() and JarFinder#zipDir() have such code:
> {code}
> 99 InputStream is = new FileInputStream(f);
> 100 copyToZipStream(is, anEntry, zos);
> {code}
> The InputStream is not closed after copy operation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
