[
https://issues.apache.org/jira/browse/HBASE-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973342#comment-13973342
]
stack commented on HBASE-11015:
-------------------------------
Thanks for the patch Yi Deng.
Why you making the change? You have numbers or a use case you are improving
for or is it just an 'itch'?
Rather than HRegionIf, maybe call it 'Region'? (See where we have Store and
HStore as the implementation).
No need to put HSTORE_BLOCKING_STORE_FILES_KEY in HConstants? Put into class
where it is used in MSFlusher? (HConstants is a bit of anti-pattern -- good for
constants used in many packages)
Does this need to be in HRegion as a public method:
+ public int maxStoreFilesCount() {
Would a utiltiy method do here instead? (Should be called
getMaxStoreFileCount?)
Look at other Interfaces in HBase. See how they do not have the public
qualifiers. I bring it up because a kind heart went through all of our
Interfaces and removed the 'public' qualifiers intentionally (They are not
needed on Interfaces).
On this:
HRegionServerIf
There is a RegionServerServices interface all ready? You didn't want to use
that?
How are these done currently? The Master runs them IIRC?
+ /**
+ * Requests the region server to make a split on a specific region-store.
+ */
+ public boolean requestSplit(HRegionIf r);
+
+ /**
+ * Requests the region server to make a compaction on a specific
region-store.
+ *
+ * @param r the region-store.
+ * @param why Why compaction requested -- used in debug messages
+ */
+ public void requestCompaction(HRegionIf r, String why);
I reviewed about half of the patch.
> Some refactoring on MemStoreFlusher
> -----------------------------------
>
> Key: HBASE-11015
> URL: https://issues.apache.org/jira/browse/HBASE-11015
> Project: HBase
> Issue Type: Bug
> Components: io
> Reporter: Yi Deng
> Labels: patch
> Fix For: 0.89-fb
>
> Attachments: D1264374.diff.txt
>
>
> Use `ScheduledThreadPoolExecutor`
> Change some logic
> Add testcase
--
This message was sent by Atlassian JIRA
(v6.2#6252)
