[
https://issues.apache.org/jira/browse/HBASE-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973552#comment-13973552
]
Hadoop QA commented on HBASE-11018:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12640703/HBASE-11018-trunk.patch
against trunk revision .
ATTACHMENT ID: 12640703
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9321//console
This message is automatically generated.
> ZKUtil.getChildDataAndWatchForNewChildren() will not return null as indicated
> -----------------------------------------------------------------------------
>
> Key: HBASE-11018
> URL: https://issues.apache.org/jira/browse/HBASE-11018
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
> Affects Versions: 0.96.1, 0.98.1
> Reporter: Jerry He
> Assignee: Jerry He
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-11018-trunk.patch
>
>
> While working on HBase acl, I found out that
> ZKUtil.getChildDataAndWatchForNewChildren() will not return null as
> indicated. Here is the code:
> {code}
> /**
> ....
> * Returns null if the specified node does not exist. Otherwise returns a
> * list of children of the specified node. If the node exists but it has no
> * children, an empty list will be returned.
> ....
> */
> public static List<NodeAndData> getChildDataAndWatchForNewChildren(
> ZooKeeperWatcher zkw, String baseNode) throws KeeperException {
> List<String> nodes =
> ZKUtil.listChildrenAndWatchForNewChildren(zkw, baseNode);
> List<NodeAndData> newNodes = new ArrayList<NodeAndData>();
> if (nodes != null) {
> for (String node : nodes) {
> String nodePath = ZKUtil.joinZNode(baseNode, node);
> byte[] data = ZKUtil.getDataAndWatch(zkw, nodePath);
> newNodes.add(new NodeAndData(nodePath, data));
> }
> }
> return newNodes;
> }
> {code}
> We return 'newNodes' which will never be null.
> This is a deprecated method. But it is still used in HBase code.
> For example:
> org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.start()
> {code}
> public void start() throws KeeperException {
> watcher.registerListener(this);
> if (ZKUtil.watchAndCheckExists(watcher, aclZNode)) {
> List<ZKUtil.NodeAndData> existing =
> ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode);
> if (existing != null) {
> refreshNodes(existing);
> }
> }
> }
> {code}
> We test the 'null' return from the call which becomes the problem.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
