[ 
https://issues.apache.org/jira/browse/HBASE-10935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974179#comment-13974179
 ] 

Ted Yu commented on HBASE-10935:
--------------------------------

{code}
+          LOG.debug("take snapshot without flush memstore first");
{code}
'without flush' -> 'without flushing'
{code}
+         * To minimized the code change, I will not change the class name.
{code}
Change the second part of the sentence to 'class name is not changed'

Please attach patch for trunk.
Also, update release note.

> support snapshot policy where flush memstore can be skipped to prevent 
> production cluster freeze
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10935
>                 URL: https://issues.apache.org/jira/browse/HBASE-10935
>             Project: HBase
>          Issue Type: New Feature
>          Components: shell, snapshots
>    Affects Versions: 0.94.7, 0.94.18
>            Reporter: Tianying Chang
>            Assignee: Tianying Chang
>            Priority: Minor
>             Fix For: 0.94.20
>
>         Attachments: HBase-10935.patch
>
>
> We are using snapshot feature to do HBase disaster recovery. We will do 
> snapshot in our production cluster periodically. The current flush snapshot 
> policy require all regions of the table to coordinate to prevent write and do 
> flush at the same time. Since we use WALPlayer to complete the data that is 
> not in the snapshot HFile, we don't need the snapshot to do coordinated 
> flush. The snapshot just recored all the HFile that are already there. 
> I added the parameter in the HBase shell. So people can choose to use the 
> NoFlush snapshot when they need, like below. Otherwise, the default flush 
> snpahot support is not impacted. 
> >snaphot 'TestTable', 'TestSnapshot', 'skipFlush'



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to