[
https://issues.apache.org/jira/browse/HBASE-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975058#comment-13975058
]
stack commented on HBASE-10974:
-------------------------------
bq. TestProcedureManager generally fails when i run the test suite. Is it
really under the small tests category? Or should it be medium tests? Because we
are starting a cluster there.
The "16.7.2.2. Medium Tests" in refguide has medium tests taking < 50 seconds.
FYI.
Looking at decodeNext, what in particular am I looking at? The
ensureSpaceForKey?
bq. So except for the common bytes the remaining bytes are copied for every
next().
I just see us copying the full key, not the difference. Am I looking in the
wrong place boss?
bq. Existing code will only get 50 bytes - the uncommon part from the common
buffer.
... where is this going on? (Sorry for being dense)
How do I interpret your math? The new code is 'worse' if doing a get but
better when scanning?
Thanks Ram.
> Improve DBEs read performance by avoiding byte array deep copies for key[]
> and value[]
> --------------------------------------------------------------------------------------
>
> Key: HBASE-10974
> URL: https://issues.apache.org/jira/browse/HBASE-10974
> Project: HBase
> Issue Type: Improvement
> Components: Scanners
> Affects Versions: 0.99.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10974_1.patch
>
>
> As part of HBASE-10801, we tried to reduce the copy of the value [] in
> forming the KV from the DBEs.
> The keys required copying and this was restricting us in using Cells and
> always wanted to copy to be done.
> The idea here is to replace the key byte[] as ByteBuffer and create a
> consecutive stream of the keys (currently the same byte[] is used and hence
> the copy). Use offset and length to track this key bytebuffer.
> The copy of the encoded format to normal Key format is definitely needed and
> can't be avoided but we could always avoid the deep copy of the bytes to form
> a KV and thus use cells effectively. Working on a patch, will post it soon.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
