[
https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979099#comment-13979099
]
Andrew Purtell commented on HBASE-11052:
----------------------------------------
Looks good to me.
For 0.98 and 0.96 we could keep the default in the code for
hbase.regionserver.thrift.compact and hbase.regionserver.thrift.framed as
'false' but add entries to hbase-default.xml for these as 'true' with a note in
the description that changing it back to the old default exposes the service to
DoS.
> Sending random data crashes thrift service
> ------------------------------------------
>
> Key: HBASE-11052
> URL: https://issues.apache.org/jira/browse/HBASE-11052
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Affects Versions: 0.98.1, 1.0.0, 0.94.18
> Reporter: Adrian Muraru
> Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_trunk_v1.patch
>
>
> Upstream thrift library has a know issue (THRIFT-601) causing the thrift
> server to crash with an Out-of-Memory Error when bogus requests are sent.
> This reproduces when a very large request size is sent in the request header,
> making the thrift server to allocate a large memory segment leading to OOM.
> LoadBalancer health checks are the first "candidate" for bogus requests
> Thrift developers admit this is a known issue with TBinaryProtocol and their
> recommandation is to use TCompactProtocol/TFramedTransport but this requires
> all thrift clients to be updated (might not be feasible atm)
> So we need a fix similar to CASSANDRA-475.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
