[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980386#comment-13980386
]
stack commented on HBASE-11069:
-------------------------------
Similar comments as those over on the split patch.
We don't init and start the consensus on this one though:
- if (RegionMergeTransaction.transitionMergingNode(watcher, p,
+ ConsensusProvider consensus =
ConsensusProviderFactory.getConsensusProvider(server.getConfiguration());
+ if (consensus.getRegionMergeConsensus().transitionMergingNode(watcher,
p,
hri_a, hri_b, sn, -1, EventType.RS_ZK_REQUEST_REGION_MERGE,
Should the split and merge be symmetrical?
And we are passing in zk:
- createNodeMerging(server.getZooKeeper(), this.mergedRegionInfo,
- server.getServerName(), region_a.getRegionInfo(),
region_b.getRegionInfo());
+
consensus.getRegionMergeConsensus().createNodeMerging(server.getZooKeeper(),
+ this.mergedRegionInfo, server.getServerName(),
region_a.getRegionInfo(),
+ region_b.getRegionInfo());
when I'd expect it to be hidden behind the Interface buried in the
implementation (if possible).
Good stuff Sergey.
> Decouple region merging from ZooKeeper
> --------------------------------------
>
> Key: HBASE-11069
> URL: https://issues.apache.org/jira/browse/HBASE-11069
> Project: HBase
> Issue Type: Sub-task
> Components: Consensus, Zookeeper
> Reporter: Sergey Soldatov
> Attachments: HBASE-11069.patch
>
>
> As part of HBASE-10296 Region Merge should be decoupled from Zookeeper.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
