[ 
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Antonov updated HBASE-10915:
------------------------------------

    Attachment: HBASE-10915.patch

Updated patch. A few notes, follow up from review at 
https://reviews.apache.org/r/20337:

 - w.r.t how to convert protobuf request for region closing to instance of 
CloseRegionDetails - I'd appreciate more feedback on the proper way of doing 
that. It definitely seems a bit odd, but the point is: we need to convert the 
proto request to consensus details object at some point, as we need to carry 
znode version throughout the code flow to check it (in current implementation, 
unfortunately), and we would like to convert it transparently for 
RSRpcServices. [~stack] - what do you think?
 - fixed the regression when the KeeperException was swallowed in consensus 
code without abording server (old behavior i've restored now).
 - regarding improving the code which just logs the error in some cases - I'd 
prefer to do that in separate jira, as not sure yet what's the rigth behavior. 
Just a bit reluctant about simply calling server.abort() on each such case..

On the ClosedRegionHandler. The code we talked about above, in this patch I 
didn't move it to AM, as there's another jira (HBASE-7767) to get rid of 
ZKTable (or rework it to TableState interface with table-based and zk-based 
implementation).  Thoughts?

> Decouple region closing (HM and HRS) from ZK
> --------------------------------------------
>
>                 Key: HBASE-10915
>                 URL: https://issues.apache.org/jira/browse/HBASE-10915
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Consensus, Zookeeper
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>         Attachments: HBASE-10915.patch, HBASE-10915.patch, HBASE-10915.patch, 
> HBASE-10915.patch, HBASE-10915.patch, HBASE-10915.patch, HBASE-10915.patch, 
> HBASE-10915.patch, HBASE-10915.patch
>
>
> Decouple region closing from ZK. 
> Includes RS side (CloseRegionHandler), HM side (ClosedRegionHandler) and the 
> code using (HRegionServer, RSRpcServices etc).
> May need small changes in AssignmentManager.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to