[
https://issues.apache.org/jira/browse/HBASE-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981720#comment-13981720
]
Hadoop QA commented on HBASE-10960:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12642010/hbase-10960.v3.patch
against trunk revision .
ATTACHMENT ID: 12642010
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ append_call method_call = new append_call(append, resultHandler,
this, ___protocolFactory, ___transport);
+ checkAndPut_call method_call = new checkAndPut_call(tableName, row,
column, value, mput, attributes, resultHandler, this, ___protocolFactory,
___transport);
+ result.success = iface.checkAndPut(args.tableName, args.row,
args.column, args.value, args.mput, args.attributes);
+ private static final Map<Class<? extends IScheme>, SchemeFactory> schemes
= new HashMap<Class<? extends IScheme>, SchemeFactory>();
+ /** The set of fields this struct contains, along with convenience methods
for finding and manipulating them. */
+ if (fields == null) throw new IllegalArgumentException("Field " +
fieldId + " doesn't exist!");
+ /** Returns true if field corresponding to fieldID is set (has been
assigned a value) and false otherwise */
+ private void readObject(java.io.ObjectInputStream in) throws
java.io.IOException, ClassNotFoundException {
+ // check for required fields of primitive type, which can't be checked
in the validate method
+ private static final Map<Class<? extends IScheme>, SchemeFactory> schemes
= new HashMap<Class<? extends IScheme>, SchemeFactory>();
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9402//console
This message is automatically generated.
> Enhance HBase Thrift 1 to include "append" and "checkAndPut" operations
> -----------------------------------------------------------------------
>
> Key: HBASE-10960
> URL: https://issues.apache.org/jira/browse/HBASE-10960
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Fix For: 0.99.0
>
> Attachments: HBASE-10960.patch, hbase-10960.v3.patch
>
>
> Both append, and checkAndPut functionalities are available in Thrift 2
> interface, but not in Thrift. So, adding the support for these
> functionalities in Thrift1 too.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
