[
https://issues.apache.org/jira/browse/HBASE-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983273#comment-13983273
]
Matteo Bertozzi commented on HBASE-10926:
-----------------------------------------
quick look and the code looks good to me
a couple of notes, hbase.procedure only contains the "Procedure infrastructure"
i guess you can move the flush procedure in hbase.regionserver.flushprocedure
or hbase.procedure.flush or somewhere else.
The RegionServerFlushTableProcedureManager looks like a copy-paste from the
snapshot one
can you think a way to remove some steps? I was thinking at maybe we can get
something like
OnlineRegionsProcedureManager as base class for all the operations that tries
to execute something
on all the online regions (but this may be done as separate jira).
what happens if a region is down or not responding within the timeout? no one
executes the flush?
can you document the semantic change in the Admin documentation, if the above
is true
> Use global procedure to flush table memstore cache
> --------------------------------------------------
>
> Key: HBASE-10926
> URL: https://issues.apache.org/jira/browse/HBASE-10926
> Project: HBase
> Issue Type: Improvement
> Components: Admin
> Affects Versions: 0.96.2, 0.98.1
> Reporter: Jerry He
> Assignee: Jerry He
> Fix For: 0.99.0
>
> Attachments: HBASE-10926-trunk-v1.patch
>
>
> Currently, user can trigger table flush through hbase shell or HBaseAdmin
> API. To flush the table cache, each region server hosting the regions is
> contacted and flushed sequentially, which is less efficient.
> In HBase snapshot global procedure is used to coordinate and flush the
> regions in a distributed way.
> Let's provide a distributed table flush for general use.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
