[
https://issues.apache.org/jira/browse/HBASE-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984140#comment-13984140
]
Anoop Sam John edited comment on HBASE-11093 at 4/29/14 9:09 AM:
-----------------------------------------------------------------
Why not doing this check with filterRowCells(List<Cell> ignored)? This seems
to be costlier with new List creation and all.. Also filterRow(List)
{code}
public boolean filterRow() throws IOException {
+ if (hasFilterRow != null && !hasFilterRow.booleanValue()) {
+ return false;
+ }
{code}
if(!hasFilterRow()) return false;
Will be better (?)
was (Author: anoop.hbase):
Why not doing this check with filterRowCells(List<Cell> ignored)?
{code}
public boolean filterRow() throws IOException {
+ if (hasFilterRow != null && !hasFilterRow.booleanValue()) {
+ return false;
+ }
{code}
if(!hasFilterRow()) return false;
Will be better (?)
> FilterList#filterRow() iterates through its filters even though
> FilterList#hasFilterRow() returns false
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-11093
> URL: https://issues.apache.org/jira/browse/HBASE-11093
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: 11093-v1.txt, 11093-v2.txt
>
>
> FilterList#hasFilterRow() returns false when hasFilterRow() of all of
> constituent filters return false.
> However, FilterList#filterRow() still iterates through its filters in this
> scenario.
> The iteration should be skipped when FilterList#hasFilterRow() returns false.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
