[
https://issues.apache.org/jira/browse/HBASE-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984476#comment-13984476
]
Hadoop QA commented on HBASE-11034:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12642432/HBASE-11034.1.patch
against trunk revision .
ATTACHMENT ID: 12642432
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestHBaseFsck
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9420//console
This message is automatically generated.
> Get path validates column families twice
> ----------------------------------------
>
> Key: HBASE-11034
> URL: https://issues.apache.org/jira/browse/HBASE-11034
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.98.0
> Reporter: Nick Dimiduk
> Assignee: Rekha Joshi
> Priority: Minor
> Attachments: HBASE-11034.1.patch
>
>
> HRegion#get(Get) adds/validates column families. The resulting RegionScanner
> goes through the same validation dance a second time. That second
> implementation is slightly less efficient, always checking the families, even
> if there were no user-provided families and the prepareScanner() call already
> did this. The current logic in HRegion#get() is smarter actually. Let's do
> the work only once.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
