[ 
https://issues.apache.org/jira/browse/HBASE-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992587#comment-13992587
 ] 

Qiang Tian commented on HBASE-11096:
------------------------------------

Hi [~apurtell], 

happen to find another new bug...

it looks 0.99 is in BIG refactoring... HRegionServer becomes the base class of 
HMaster, for coprocessor stuff, since they share the same run method,  the 
master will call coprocessor twice.

see below example logs, one is for real regionserver, the other is for the 
regionserver code path in master, 


2014-05-08 00:33:51,632 INFO  [M:0;bdvm135:36021] 
coprocessor.TestCoprocessorStop$FooCoprocessor(66): st
art coprocessor on regionserver

2014-05-08 00:33:51,633 INFO  [RS:0;bdvm135:47513] 
coprocessor.TestCoprocessorStop$FooCoprocessor(66): s
tart coprocessor on regionserver

...
2014-05-08 00:34:03,166 INFO  [main] regionserver.HRegionServer(1624): call 
stack of stop
java.io.IOException
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.stop(HRegionServer.java:1624)
        at 
org.apache.hadoop.hbase.master.ServerManager.shutdownCluster(ServerManager.java:975)
        at org.apache.hadoop.hbase.master.HMaster.shutdown(HMaster.java:1623)
        at 
org.apache.hadoop.hbase.util.JVMClusterUtil.shutdown(JVMClusterUtil.java:256)
        at 
org.apache.hadoop.hbase.LocalHBaseCluster.shutdown(LocalHBaseCluster.java:437)
        at 
org.apache.hadoop.hbase.MiniHBaseCluster.shutdown(MiniHBaseCluster.java:519)
        at 
org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop.testStopped(TestCoprocessorStop.java:
114)
...
2014-05-08 00:34:03,215 INFO  [main] regionserver.HRegionServer(1629): rsHost 
code path called

2014-05-08 00:34:03,228 DEBUG [main] coprocessor.CoprocessorHost(258): Stop 
coprocessor org.apache.hadoo
p.hbase.coprocessor.TestCoprocessorStop$FooCoprocessor
2014-05-08 00:34:03,462 INFO  [main] 
coprocessor.TestCoprocessorStop$FooCoprocessor(88): create file hdf
s://localhost:8155/user/tianq/test-data/f0c9423c-e505-4feb-907e-c7bd6e16545b/regionserver1399534399680
 r
eturn rc true

...

2014-05-08 00:34:03,482 INFO  [main] regionserver.HRegionServer(1624): call 
stack of stop
java.io.IOException
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.stop(HRegionServer.java:1624)
        at 
org.apache.hadoop.hbase.util.JVMClusterUtil.shutdown(JVMClusterUtil.java:264)
        at 
org.apache.hadoop.hbase.LocalHBaseCluster.shutdown(LocalHBaseCluster.java:437)
        at 
org.apache.hadoop.hbase.MiniHBaseCluster.shutdown(MiniHBaseCluster.java:519)
        at 
org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop.testStopped(TestCoprocessorStop.java:
114)
2014-05-08 00:34:03,485 INFO  [main] regionserver.HRegionServer(1629): rsHost 
code path called

2014-05-08 00:34:03,485 DEBUG [main] coprocessor.CoprocessorHost(258): Stop 
coprocessor org.apache.hadoo
p.hbase.coprocessor.TestCoprocessorStop$FooCoprocessor
2014-05-08 00:34:03,493 INFO  [main] 
coprocessor.TestCoprocessorStop$FooCoprocessor(88): create file hdf
s://localhost:8155/user/tianq/test-data/f0c9423c-e505-4feb-907e-c7bd6e16545b/regionserver1399534399680
 r
eturn rc false




> stop method of Master and RegionServer coprocessor  is not invoked
> ------------------------------------------------------------------
>
>                 Key: HBASE-11096
>                 URL: https://issues.apache.org/jira/browse/HBASE-11096
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.2, 0.98.1, 0.94.19
>            Reporter: Qiang Tian
>            Assignee: Qiang Tian
>             Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
>         Attachments: HBASE-11096-trunk-v0.patch, HBASE-11096-trunk-v0.patch, 
> HBASE-11096-trunk-v1.patch, HBASE-11096-trunk-v2.patch
>
>
> the stop method of coprocessor specified by 
> "hbase.coprocessor.master.classes" and  
> "hbase.coprocessor.regionserver.classes"  is not invoked.
> If coprocessor allocates OS resources, it could cause master/regionserver 
> resource leak or hang during exit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to