[
https://issues.apache.org/jira/browse/HBASE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081498#comment-13081498
]
jirapos...@reviews.apache.org commented on HBASE-4027:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1214/
-----------------------------------------------------------
(Updated 2011-08-09 07:52:09.666709)
Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, Jonathan Gray,
and Li Pi.
Changes
-------
Rebased onto 3857. Configuration added as well.
Summary
-------
Review request - I apparently can't edit tlipcon's earlier posting of my diff,
so creating a new one.
This addresses bug HBase-4027.
https://issues.apache.org/jira/browse/HBase-4027
Diffs (updated)
-----
CHANGES.txt 7c6f592
conf/hbase-env.sh 2d55d27
pom.xml 0f24681
src/docbkx/book.xml 2c19cef
src/docbkx/configuration.xml 3595e76
src/docbkx/developer.xml a3e22ea
src/docbkx/performance.xml d8e104f
src/docbkx/troubleshooting.xml 9f93cd9
src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 2d4002c
src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java 097dc50
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockCacheTestUtils.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java 88aa652
src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java 886c31d
src/main/java/org/apache/hadoop/hbase/io/hfile/SingleSizeCacheTestUtils.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/Slab.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/ipc/Delayable.java 56f0650
src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java f223e46
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 6fb1da7
src/main/java/org/apache/hadoop/hbase/mapred/Driver.java d38956c
src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java dda4241
src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
ff05df8
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 86652c0
src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java 8e87c83
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 94c8bb4
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 887f736
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
9d87fa5
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALActionsListener.java
151c90b
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALObserver.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
8e1f6e0
src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
src/main/java/org/apache/hadoop/hbase/util/FSMapRUtils.java edca7f4
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 0729410
src/main/java/org/apache/hadoop/hbase/util/PoolMap.java ebf3078
src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java a0bef34
src/main/ruby/hbase/admin.rb 4460d6e
src/site/xdoc/index.xml 8e1b531
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlab.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java 0b21c6c
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
6d83b00
src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 4387170
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java b4c407b
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java
dc43eb2
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALObserver.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
381ac90
src/test/java/org/apache/hadoop/hbase/util/TestPoolMap.java 2c565d7
Diff: https://reviews.apache.org/r/1214/diff
Testing
-------
Ran benchmarks against it in HBase standalone mode. Wrote test cases for all
classes, multithreaded test cases exist for the cache.
Thanks,
Li
> Enable direct byte buffers LruBlockCache
> ----------------------------------------
>
> Key: HBASE-4027
> URL: https://issues.apache.org/jira/browse/HBASE-4027
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Assignee: Li Pi
> Priority: Minor
> Attachments: 4027-v5.diff, 4027v7.diff, HBase-4027 (1).pdf,
> HBase-4027.pdf, HBase4027v8.diff, HBase4027v9.diff, hbase-4027-v10.diff,
> hbase-4027v6.diff, slabcachepatch.diff, slabcachepatchv2.diff,
> slabcachepatchv3.1.diff, slabcachepatchv3.2.diff, slabcachepatchv3.diff,
> slabcachepatchv4.5.diff, slabcachepatchv4.diff
>
>
> Java offers the creation of direct byte buffers which are allocated outside
> of the heap.
> They need to be manually free'd, which can be accomplished using an
> documented {{clean}} method.
> The feature will be optional. After implementing, we can benchmark for
> differences in speed and garbage collection observances.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
