[
https://issues.apache.org/jira/browse/HBASE-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000626#comment-14000626
]
Anoop Sam John commented on HBASE-10835:
----------------------------------------
{code}
5 warnings
[WARNING] Javadoc Warnings
[WARNING] javadoc: warning - Multiple sources of package comments found for
package "org.apache.hadoop.hbase.io.hfile"
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileDataBlockEncoder.java:47:
warning - Tag @link: can't find endBlockEncoding(HFileBlockEncodingContext,
DataOutputStream, byte[]) in
org.apache.hadoop.hbase.io.hfile.HFileDataBlockEncoder
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/package-info.java:119:
warning - Tag @link: reference not found:
CacheConfig#SLAB_CACHE_OFFHEAP_PERCENTAGE_KEY
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/package-info.java:119:
warning - Tag @link: reference not found: HConstants#HFILE_BLOCK_CACHE_SIZE_KEY
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/package-info.java:119:
warning - Tag @link: reference not found:
CacheConfig#BUCKET_CACHE_COMBINED_PERCENTAGE_KEY
[INFO]
{code}
Out of this only one warn regarding HFileDataBlockEncoder is introduced by this
patch. I can correct that on commit.
> DBE encode path improvements
> ----------------------------
>
> Key: HBASE-10835
> URL: https://issues.apache.org/jira/browse/HBASE-10835
> Project: HBase
> Issue Type: Improvement
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.99.0
>
> Attachments: HBASE-10835.patch, HBASE-10835_V2.patch,
> HBASE-10835_V3.patch, HBASE-10835_V4.patch
>
>
> Here 1st we write KVs (Cells) into a buffer and then passed to DBE encoder.
> Encoder again reads kvs one by one from the buffer and encodes and creates a
> new buffer.
> There is no need to have this model now. Previously we had option of no
> encode in disk and encode only in cache. At that time the read buffer from a
> HFile block was passed to this and encodes.
> So encode cell by cell can be done now. Making this change will need us to
> have a NoOp DBE impl which just do the write of a cell as it is with out any
> encoding.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
