[
https://issues.apache.org/jira/browse/HBASE-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000593#comment-14000593
]
Hadoop QA commented on HBASE-11108:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645309/HBASE-11108.patch
against trunk revision .
ATTACHMENT ID: 12645309
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 115
new or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * @throws org.apache.hadoop.hbase.CoordinatedStateException if error
happened in underlying coordination engine
+ public static final String HBASE_COORDINATED_STATE_MANAGER_CLASS =
"hbase.coordinated.state.manager.class";
+ CoordinatedStateManager cp =
CoordinatedStateManagerFactory.getCoordinatedStateManager(conf);
+ private void handleEnableTable() throws IOException,
CoordinatedStateException, InterruptedException {
+ CoordinatedStateManager cp =
CoordinatedStateManagerFactory.getCoordinatedStateManager(HTU.getConfiguration());
+ CoordinatedStateManager cp =
CoordinatedStateManagerFactory.getCoordinatedStateManager(HTU.getConfiguration());
+ CoordinatedStateManager cp =
CoordinatedStateManagerFactory.getCoordinatedStateManager(HTU.getConfiguration());
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestHBaseFsck
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9528//console
This message is automatically generated.
> Split ZKTable into interface and implementation
> -----------------------------------------------
>
> Key: HBASE-11108
> URL: https://issues.apache.org/jira/browse/HBASE-11108
> Project: HBase
> Issue Type: Sub-task
> Components: Consensus, Zookeeper
> Affects Versions: 0.99.0
> Reporter: Konstantin Boudnik
> Assignee: Mikhail Antonov
> Attachments: HBASE-11108.patch, HBASE-11108.patch, HBASE-11108.patch,
> HBASE-11108.patch, HBASE-11108.patch
>
>
> In HBASE-11071 we are trying to split admin handlers away from ZK. However, a
> ZKTable instance is being used in multiple places, hence it would be
> beneficial to hide its implementation behind a well defined interface.
--
This message was sent by Atlassian JIRA
(v6.2#6252)