[ 
https://issues.apache.org/jira/browse/HBASE-11199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001953#comment-14001953
 ] 

stack commented on HBASE-11199:
-------------------------------

[~ndimiduk] We should do that but in a different JIRA?

Misty, you need to update to latest before you generate the patch.  You have 
changes that are undoing work that has happened since you last rebase (or do a 
diff against current head):

E.g. conf/hbase-env.sh
hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java

You could limit your diff to the directories that contain the docbook stuff.  
That'd help avoid your including unrelated changes.

Otherwise, sounds great to me.  Until we find the command-line tool to enforce 
formatting, I think devs will be inclined to follow the convention of the 
existing xml.

Good stuff [~misty]



> One-time effort to pretty-print the Docbook XML, to make further patch review 
> easier
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-11199
>                 URL: https://issues.apache.org/jira/browse/HBASE-11199
>             Project: HBase
>          Issue Type: Task
>          Components: documentation
>            Reporter: Misty Stanley-Jones
>            Assignee: Misty Stanley-Jones
>         Attachments: HBASE-11199.patch
>
>
> Careful not to pretty-print literal layouts and document (at least in this 
> JIRA) the pretty-printing process for next time.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to