[ 
https://issues.apache.org/jira/browse/HBASE-11201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002419#comment-14002419
 ] 

Jerry He commented on HBASE-11201:
----------------------------------

Hi, Ted

bq. Should barrierReleasedByMember(String member) be kept which passes null to 
the new method ?
{code}
Procedure.barrierReleasedByMember(String member, byte[] dataFromMember)
{code} 
is called by 
{code}
ProcedureCoordinator.memberFinishedBarrier(String procName, final String 
member, byte[] dataFromMember)
{code}
which in turn is called in ZKProcedureCoordinatorRpcs() if there is any 
'finished' node activity.
I don't image a need to keep the old barrierReleasedByMember(String member), 
unless we want to do something like this:
  if there is no user data on the 'finished' node, then call the old method
But that is probably an overkill.

But a good reminder. I probably need to add guard for null checking in there.

> Enable global procedure members to return values to procedure master
> --------------------------------------------------------------------
>
>                 Key: HBASE-11201
>                 URL: https://issues.apache.org/jira/browse/HBASE-11201
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11201-trunk-v1.patch
>
>
> Currently in the global procedure framework, the procedure coordinator can 
> send data (procedure argument) to the members when starting procedure.
> But we don't support getting data returned from the procedure members back to 
> the master.
> Similar to RPC and normal procedure/function calls, in many cases, this is a 
> useful capability.
> The infrastructure is in place. We just need to plug in the holes and make it 
> happen.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to