[
https://issues.apache.org/jira/browse/HBASE-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003045#comment-14003045
]
Anoop Sam John commented on HBASE-11202:
----------------------------------------
{code}
+ /**
+ * Return HStore instance. Does do do any copy: as the number of store is
limited, we
+ * iterate on the list.
+ */
+ private Store getStore(Cell cell) {
{code}
You mean "Does not do"?
{code}
- /**
- * Lock the updates' readLock first, so that we could safely append logs in
coprocessors.
- * @throws RegionTooBusyException
- * @throws InterruptedIOException
- */
- public void updatesLock() throws RegionTooBusyException,
InterruptedIOException {
- lock(updatesLock.readLock());
- }
-
- /**
- * Unlock the updates' readLock after appending logs in coprocessors.
- * @throws InterruptedIOException
- */
- public void updatesUnlock() throws InterruptedIOException {
- updatesLock.readLock().unlock();
- }
{code}
Is this removal ok? The comment itself says that it is intended to be used
from CPs. So what if someone used this already? I dont know which Jira issue
added these 2 public methods.
> Cleanup on HRegion class
> ------------------------
>
> Key: HBASE-11202
> URL: https://issues.apache.org/jira/browse/HBASE-11202
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.99.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: 11202.v1.patch
>
>
> This is mostly trivial stuff
> - remove some methods not used
> - typos
> - remove some @param w/o any info
> - change the code that uses deprecated methods
> The only non trivial change is when we get the store from a cell: instead of
> using the map, we iterate on the key set. Likely, it would be better to hava
> a sorted array instead of a Map, as the number of store is fixed. Could be
> done in a later patch.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
