[ 
https://issues.apache.org/jira/browse/HBASE-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009622#comment-14009622
 ] 

Hadoop QA commented on HBASE-11232:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12646175/HBASE-11232-0.94.diff
  against trunk revision .
  ATTACHMENT ID: 12646175

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9599//console

This message is automatically generated.

> Region fail to release the updatelock for illegal CF in multi row mutations
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-11232
>                 URL: https://issues.apache.org/jira/browse/HBASE-11232
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.19
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>         Attachments: HBASE-11232-0.94.diff
>
>
> The failback code in processRowsWithLocks did not check the column family. If 
> there is an illegal CF in the muation, it will  throw NullPointException and 
> the update lock will not be released.  So the region can not be flushed and 
> compacted. 
> HRegion #4946
> {code}
>         if (!mutations.isEmpty() && !walSyncSuccessful) {
>           LOG.warn("Wal sync failed. Roll back " + mutations.size() +
>               " memstore keyvalues for row(s):" +
>               processor.getRowsToLock().iterator().next() + "...");
>           for (KeyValue kv : mutations) {
>             stores.get(kv.getFamily()).rollback(kv);
>           }
>         }
>         // 11. Roll mvcc forward
>         if (writeEntry != null) {
>           mvcc.completeMemstoreInsert(writeEntry);
>           writeEntry = null;
>         }
>         if (locked) {
>           this.updatesLock.readLock().unlock();
>           locked = false;
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to