[ 
https://issues.apache.org/jira/browse/HBASE-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011816#comment-14011816
 ] 

Hadoop QA commented on HBASE-11259:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12647223/HBASE-11259.patch
  against trunk revision .
  ATTACHMENT ID: 12647223

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9627//console

This message is automatically generated.

> Compression.java different compressions load system classpath differently 
> causing errors
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-11259
>                 URL: https://issues.apache.org/jira/browse/HBASE-11259
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.99.0
>            Reporter: Enoch Hsu
>            Assignee: Enoch Hsu
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11259.patch
>
>
> I stumbled upon this issue when testing Snappy compression on hbase tables 
> with a webserver.
> On the webserver the system classpath of the server JVM did not include the 
> path to hadoop-common.jar and since it is hardcoded to only retrieve the 
> system classpath it ran into a NoClassDefFoundException using hte following 
> call ClassLoader.getSystemClassLoader()
> However LZ4 compression works using this private method 
> getClassLoaderForCodec() which attempts to load the threads classpath first 
> and the system classpath last.
> I propose to change all the  ClassLoader.getSystemClassLoader() calls to 
> getClassLoaderForCodec() to allow for consistent behavior in loading 
> compression classes and to also make it easier for users to make sure they do 
> not run into RuntimeExceptions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to