[
https://issues.apache.org/jira/browse/HBASE-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016349#comment-14016349
]
Hudson commented on HBASE-11279:
--------------------------------
FAILURE: Integrated in HBase-TRUNK #5170 (See
[https://builds.apache.org/job/HBase-TRUNK/5170/])
HBASE-11279 Block cache could be disabled by mistake (jxiang: rev
369141b79554f625752d0f6497e1426b3fa284e8)
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingKeyRange.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
> Block cache could be disabled by mistake
> ----------------------------------------
>
> Key: HBASE-11279
> URL: https://issues.apache.org/jira/browse/HBASE-11279
> Project: HBase
> Issue Type: Bug
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: hbase-11279.patch
>
>
> There is a weird test failure:
> {noformat}
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.hadoop.hbase.io.hfile.TestPrefetch.readStoreFile(TestPrefetch.java:96)
> at
> org.apache.hadoop.hbase.io.hfile.TestPrefetch.testPrefetch(TestPrefetch.java:66)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {noformat}
> Looked into it, and found it could be because CacheConfig tries to compare a
> float with a long. Probably we should do this instead:
> {noformat}
> - if (cachePercentage == 0L) {
> + if (cachePercentage <= 0.0001f) {
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
