[ 
https://issues.apache.org/jira/browse/HBASE-11280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017752#comment-14017752
 ] 

stack commented on HBASE-11280:
-------------------------------

This is great (I like this kind of stuff '<firstterm>Write Ahead Log 
(WAL)</firstterm> records")

Location looks correct to me.

Change this "The WAL implementation used by HBase is " because the HLog you 
point to is only an Interface.  Implementations implement this Interface.  
Currently there is one only but attempts have been made at doing others and we 
may be doing a new one soon to do multiwal.

Change this "One HLog instance exists" ... to be instead "Usually there is one 
instance of a WAL only per RegionServer..." (there is one HLog implementatoin 
true but I think you are trying to say one WAL here).  We intend there to be 
many in the hopefully not too distant future.

WALs used to be kept under  <filename>/hbase/.logs/</filename> in and before 
0.94.  Now they are in  <filename>/hbase/WALs</filename>

The description of '+            <title>WAL Splitting, Step by Step</title>' 
applies to Distributed Log Splitting.  You might want to call it out as so?

Maybe mention that the HMaster enrolls all regionservers in the log splitting 
process farming log splitting process to the regionservers.

That is what I have so far (about half way through review)



> Document distributed log replay and distributed log splitting
> -------------------------------------------------------------
>
>                 Key: HBASE-11280
>                 URL: https://issues.apache.org/jira/browse/HBASE-11280
>             Project: HBase
>          Issue Type: Sub-task
>          Components: documentation, MTTR, wal
>            Reporter: Misty Stanley-Jones
>            Assignee: Misty Stanley-Jones
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11280.patch
>
>
> Enable 'distributed log replay' by default.  Depends on hfilev3 being enabled.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to