[ 
https://issues.apache.org/jira/browse/HBASE-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017925#comment-14017925
 ] 

Andrew Purtell commented on HBASE-11263:
----------------------------------------

bq. Ok.  +1 then.  Work for a thread pool at server level would be in a 
different JIRA I presume.

I'd argue not much point for this change if thread pool at server level is 
being worked on now or next.

> Share the open/close store file thread pool for all store in a region
> ---------------------------------------------------------------------
>
>                 Key: HBASE-11263
>                 URL: https://issues.apache.org/jira/browse/HBASE-11263
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.99.0
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-11263-trunk-v1.diff
>
>
> Currently, the open/close store file thread pool is divided equally to all 
> stores of a region. 
> {code}
>   protected ThreadPoolExecutor getStoreFileOpenAndCloseThreadPool(
>       final String threadNamePrefix) {
>     int numStores = Math.max(1, this.htableDescriptor.getFamilies().size());
>     int maxThreads = Math.max(1,
>         conf.getInt(HConstants.HSTORE_OPEN_AND_CLOSE_THREADS_MAX,
>             HConstants.DEFAULT_HSTORE_OPEN_AND_CLOSE_THREADS_MAX)
>             / numStores);
>     return getOpenAndCloseThreadPool(maxThreads, threadNamePrefix);
>   }
> {code}
> This is not very optimal in following scenarios:
> # The data of some column families are very large and there are many hfiles 
> in those stores, and others may be very small and in-memory column families. 
> # Usually we preserve some column families for later needs. The thread pool 
> for these column families are wasted。
> The simple way is to share a big thread pool for all stores to open/close 
> hfiles.  
> Suggestions are welcomed. 
> Thanks. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to