[
https://issues.apache.org/jira/browse/HBASE-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021081#comment-14021081
]
stack commented on HBASE-11120:
-------------------------------
Why did the patch go from 21k to 6k [~misty]? Did you get less ambitious?
Looking the below:
{code}
<entry>hbase.hstore.compaction.min.size</entry>
<entry>A StoreFile smaller than this size (in bytes) will
always be eligible for
minor compaction.</entry>
- <entry>10</entry>
+ <entry>128 MB</entry>
</row>
<row>
<entry>hbase.hstore.compaction.max.size</entry>
<entry>A StoreFile larger than this size (in bytes) will
be excluded from minor
compaction.</entry>
- <entry>1000</entry>
+ <entry>Long.MAX_VALUE</entry>
{code}
... I don't see hbase.hstore.compaction.min.size in code base any more and you
can't write Long.MAX_VALUE or 128 MB as values... our configuration system
can't digest anything but numbers.
Let me know why big difference in size. Maybe this patch should have had more
in it? Thanks.
> Update documentation about major compaction algorithm
> -----------------------------------------------------
>
> Key: HBASE-11120
> URL: https://issues.apache.org/jira/browse/HBASE-11120
> Project: HBase
> Issue Type: Bug
> Components: Compaction, documentation
> Affects Versions: 0.98.2
> Reporter: Misty Stanley-Jones
> Assignee: Misty Stanley-Jones
> Attachments: HBASE-11120-2.patch, HBASE-11120-3-rebased.patch,
> HBASE-11120-3.patch, HBASE-11120-4-rebased.patch, HBASE-11120-4.patch,
> HBASE-11120.patch
>
>
> [14:20:38] <jdcryans> seems that there's
> http://hbase.apache.org/book.html#compaction and
> http://hbase.apache.org/book.html#managed.compactions
> [14:20:56] <jdcryans> the latter doesn't say much, except that you
> should manage them
> [14:21:44] <jdcryans> the former gives a good description of the
> _old_ selection algo
> [14:45:25] <jdcryans> this is the new selection algo since C5 /
> 0.96.0: https://issues.apache.org/jira/browse/HBASE-7842
--
This message was sent by Atlassian JIRA
(v6.2#6252)
