[ https://issues.apache.org/jira/browse/HBASE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027260#comment-14027260 ]
Hadoop QA commented on HBASE-11094: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649686/hbase-11094-v5.1.patch against trunk revision . ATTACHMENT ID: 12649686 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 35 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + result = result && (hasOpenForDistributedLogReplay() == other.hasOpenForDistributedLogReplay()); + new java.lang.String[] { "Region", "VersionOfOfflineNode", "FavoredNodes", "OpenForDistributedLogReplay", }); {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileGetting(TestHRegion.java:3499) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9738//console This message is automatically generated. > Distributed log replay is incompatible for rolling restarts > ----------------------------------------------------------- > > Key: HBASE-11094 > URL: https://issues.apache.org/jira/browse/HBASE-11094 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: Jeffrey Zhong > Priority: Blocker > Fix For: 0.99.0 > > Attachments: hbase-11094-v2.patch, hbase-11094-v3.patch, > hbase-11094-v4.patch, hbase-11094-v5.1.patch, hbase-11094-v5.patch, > hbase-11094.patch > > > 0.99.0 comes with dist log replay by default (HBASE-10888). However, reading > the code and discussing this with Jeffrey, we realized that the dist log > replay code is not compatible with rolling upgrades from 0.98.0 and 1.0.0. > The issue is that, the region server looks at it own configuration to decide > whether the region should be opened in replay mode or not. The open region > RPC does not contain that info. So if dist log replay is enabled on master, > the master will assign the region and schedule replay tasks. If the region is > opened in a RS that does not have this conf enabled, then it will happily > open the region in normal mode (not replay mode) causing possible (transient) > data loss. -- This message was sent by Atlassian JIRA (v6.2#6252)