[
https://issues.apache.org/jira/browse/HBASE-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028933#comment-14028933
]
Hadoop QA commented on HBASE-11335:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12649958/HBASE_11335-trunk-v1.patch
against trunk revision .
ATTACHMENT ID: 12649958
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9754//console
This message is automatically generated.
> Fix the TABLE_DIR param in TableSnapshotInputFormat
> ---------------------------------------------------
>
> Key: HBASE-11335
> URL: https://issues.apache.org/jira/browse/HBASE-11335
> Project: HBase
> Issue Type: Bug
> Components: mapreduce, snapshots
> Affects Versions: 0.96.2, 0.98.3
> Reporter: deepankar
> Attachments: HBASE_11335-0.96-v1.patch, HBASE_11335-trunk-v1.patch
>
>
> In class *TableSnapshotInputFormat* or *TableSnapshotInputFormatImpl*
> in the function
> {code}
> public static void setInput(Job job, String snapshotName, Path restoreDir)
> throws IOException {
> {code}
> we are setting restoreDir (temporary root) to tableDir
> {code}
> conf.set(TABLE_DIR_KEY, restoreDir.toString());
> {code}
> The above parameter is used to get the InputSplits, especially for
> calculating favorable hosts in the function
> {code}
> Path tableDir = new Path(conf.get(TABLE_DIR_KEY));
> List<String> hosts = getBestLocations(conf,
> HRegion.computeHDFSBlocksDistribution(conf, htd, hri, tableDir));
> {code}
> This will lead to returning a empty *HDFSBlocksDistribution*, as there is
> will be no directory with name as the region name from hri in the restored
> root directory, which will lead to scheduling of non local tasks.
> The change is simple in the sense, is to call the
> {code}FSUtils.getTableDir(rootDir, tableDesc.getTableName()) {code}
> in the getSplits function
> more discussion in the comments below
> https://issues.apache.org/jira/browse/HBASE-8369?focusedCommentId=14012085&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14012085
--
This message was sent by Atlassian JIRA
(v6.2#6252)
