[ 
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085207#comment-13085207
 ] 

Jean-Daniel Cryans commented on HBASE-4199:
-------------------------------------------

I'm sorta confused by TestBlockCacheSummary.testBlockCacheSummary, you have 3 
region servers but then you create a BC from StoreFile.getBlockCache that isn't 
related to any RS (because the get a different conf object in 
MiniHBaseCluster.init). What is it testing exactly? Do you need 3 RS btw?

You should set BlockCacheSummaryEntry's attributes to some default values 
because you might end up with NPEs that are hard to debug, just a precaution 
with Writables.

There's some cleanup to do too, long lines and whatnot.

> blockCache summary - backend
> ----------------------------
>
>                 Key: HBASE-4199
>                 URL: https://issues.apache.org/jira/browse/HBASE-4199
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Doug Meil
>            Assignee: Doug Meil
>            Priority: Minor
>         Attachments: java_HBASE_4199.patch
>
>
> This is the backend work for the blockCache summary.  Change to BlockCache 
> interface, Summarization in LruBlockCache, BlockCacheSummaryEntry, addition 
> to HRegionInterface, and HRegionServer.
> This will NOT include any of the web UI or anything else like that.  That is 
> for another sub-task.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to