[
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085214#comment-13085214
]
jirapos...@reviews.apache.org commented on HBASE-2399:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/
-----------------------------------------------------------
(Updated 2011-08-15 17:58:09.305302)
Review request for hbase.
Changes
-------
Thanks, folks. Here is the patch that fixes the whitespace issues. Should I
upload the patch to jira?
Summary
-------
1. Add tests for forcesplit multi-column-family scenarios.
2. Modify HRegion so that it picks splitpoint based on largest store, instead
of the first splittable store. It applies to both forcesplit and automatic
split.
This addresses bug hbase-2399.
https://issues.apache.org/jira/browse/hbase-2399
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
1157283
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
1157283
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
1157283
Diff: https://reviews.apache.org/r/1484/diff
Testing
-------
Thanks,
Ming
> Forced splits only act on the first family in a table
> -----------------------------------------------------
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.3
> Reporter: Jonathan Gray
> Assignee: Ming Ma
> Priority: Critical
> Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and
> then triggers a compaction (this is very similar to my current implementation
> for HBASE-2375). However, the forceSplit boolean is flipped back to false at
> the beginning of Store.compact(). So the force split only acts on the first
> family in the table. If that Store is not splittable for some reason (it is
> empty or has only one row), then the entire region will not be split,
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based
> solely on that family. If it has two rows and the next family has 1M rows,
> we pick the split key based on the two rows.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
