[
https://issues.apache.org/jira/browse/HBASE-11360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039588#comment-14039588
]
Lars Hofhansl commented on HBASE-11360:
---------------------------------------
Looks great! Nice tests. (Looking at the existing code I did not realize that
we reckeck the TS (and potentially refresh the cache) for *every* file!)
Should this:
{code}
+ @Override
+ protected boolean isFileDeletable(FileStatus fStat) {
+ return false;
}
{code}
Throw UnsupportedOperationException instead, so that it not called by accident?
In any case, +1 as is. Need to have a patch for 0.98 and trunk as well. Do you
have time/leisure to create those [~churromorales]?
Does this fix the issue for you when you deploy this in your cluster?
[~stack], what about 0.96?
> SnapshotFileCache refresh logic based on modified directory time might be
> insufficient
> --------------------------------------------------------------------------------------
>
> Key: HBASE-11360
> URL: https://issues.apache.org/jira/browse/HBASE-11360
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.19
> Reporter: churro morales
> Fix For: 0.94.22
>
> Attachments: HBASE-11360-0.94.patch
>
>
> Right now we decide whether to refresh the cache based on the lastModified
> timestamp of all the snapshots and those "running" snapshots which is located
> in the /hbase/.hbase-snapshot/.tmp/<snapshot> directory
> We ran a ExportSnapshot job which takes around 7 minutes between creating the
> directory and copying all the files.
> Thus the modified time for the
> /hbase/.hbase-snapshot/.tmp directory was 7 minutes earlier than the modified
> time of the
> /hbase/.hbase-snapshot/.tmp/<snapshot> directory
> Thus the cache refresh happens and doesn't pick up all the files but thinks
> its up to date as the modified time of the .tmp directory never changes.
> This is a bug as when the export job starts the cache never contains the
> files for the "running" snapshot and will fail.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
