[
https://issues.apache.org/jira/browse/HBASE-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085496#comment-13085496
]
[email protected] commented on HBASE-4176:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1326/
-----------------------------------------------------------
(Updated 2011-08-16 02:31:08.855007)
Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, and Jonathan Gray.
Changes
-------
- Made createFilterFromArguments static, accessing it via reflection
- Refactored TestParseFilter.java
- Removed the powerset of scannerOpenWithFilterString* methods from the Thrift
file and introduced another optional argument in the TScan struct that takes a
filterString
- Some stylistic code changes pointed out by Todd
@Todd - Could you explain further what you mean when you say - "commit this
document to be built into the docs dir as part of the build." Do you mean
inlining all the information in the document into the code as comments?
Summary
-------
https://issues.apache.org/jira/browse/HBASE-4176: Exposing HBase Filters to the
Thrift API
Currently, to use any of the filters, one has to explicitly add a scanner for
the filter in the Thrift API making it messy and long.
With this patch, I am trying to add support for all the filters in a clean way.
The user specifies a filter via a string. The string is parsed on the server to
construct the filter. More information can be found in the attached document
named Filter Language
This patch is trying to extend and further the progress made by the patches in
HBASE-1744
There is document attached to the HBASE-4176 JIRA that describes this patch in
further detail
This addresses bug HBASE-4176.
https://issues.apache.org/jira/browse/HBASE-4176
Diffs (updated)
-----
/src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java
1158073
/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
1158073
/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java
1158073
/src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
1158073
/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
1158073
/src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java
1158073
/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
1158073
/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java 1158073
/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java 1158073
/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java 1158073
/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java 1158073
/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift 1158073
/src/main/ruby/hbase/table.rb 1158073
/src/main/ruby/shell/commands/scan.rb 1158073
/src/test/java/org/apache/hadoop/hbase/filter/TestParseFilter.java 1158073
Diff: https://reviews.apache.org/r/1326/diff
Testing
-------
patch includes one test: TestParseFilter.java
Thanks,
Anirudh
> Exposing HBase Filters to the Thrift API
> ----------------------------------------
>
> Key: HBASE-4176
> URL: https://issues.apache.org/jira/browse/HBASE-4176
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Anirudh Todi
> Assignee: Anirudh Todi
> Priority: Minor
> Attachments: Filter Language(2).docx, Filter Language.docx,
> HBASE-4176.patch
>
>
> Currently, to use any of the filters, one has to explicitly add a scanner for
> the filter in the Thrift API making it messy and long. With this patch, I am
> trying to add support for all the filters in a clean way. The user specifies
> a filter via a string. The string is parsed on the server to construct the
> filter. More information can be found in the attached document named Filter
> Language
> This patch is trying to extend and further the progress made by the patches
> in the HBASE-1744 JIRA (https://issues.apache.org/jira/browse/HBASE-1744)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
