[
https://issues.apache.org/jira/browse/HBASE-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040498#comment-14040498
]
Anoop Sam John commented on HBASE-10861:
----------------------------------------
{code}
if (!(thatObject instanceof SimpleByteRange)) {
return false;
}
- SimpleByteRange that = (SimpleByteRange) thatObject;
+ SimpleMutableByteRange that = (SimpleMutableByteRange) thatObject;
{code}
Code is reachable? If we have to compare bytes in SimpleByteRange and
SimpleMutableByteRange and say equal or not, we need add instance of check for
SimpleMutableByteRange also. Then better have similar way of equals check in
SimpleMutableByteRange also.
deepCopyToNewArray, deepCopyTo, deepCopySubRangeTo -> These you want to be
exposed APIs? I think these are used within other exposed APIs. If so consider
removing them from Interface and make them as protected in AbstractByteRange (?)
public void clean() throws Exception -> What to do within this?
> Supporting API in ByteRange
> ---------------------------
>
> Key: HBASE-10861
> URL: https://issues.apache.org/jira/browse/HBASE-10861
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-10861.patch, HBASE-10861_2.patch,
> HBASE-10861_3.patch, HBASE-10861_4.patch
>
>
> We would need APIs that would
> setLimit(int limit)
> getLimt()
> asReadOnly()
> These APIs would help in implementations that have Buffers offheap (for now
> BRs backed by DBB).
> If anything more is needed could be added when needed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
