[
https://issues.apache.org/jira/browse/HBASE-11354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042237#comment-14042237
]
Nicolas Liochon commented on HBASE-11354:
-----------------------------------------
bq. Did you add DelayedClosing
I haven't double checked, but I guess it's me a long time ago in HBASE-5399.
It's sad there is no test for this, I guess it could have been done with the
environmentEdgeManager...
bq. Was it around keeping up Connections a short while in case another
connection needed zk else we'd let it go?
Yes. I do remember I tried at the beginning to stop the connection immediately.
> HConnectionImplementation#DelayedClosing does not start
> -------------------------------------------------------
>
> Key: HBASE-11354
> URL: https://issues.apache.org/jira/browse/HBASE-11354
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.99.0, 0.98.3
> Reporter: Qianxi Zhang
> Assignee: Qianxi Zhang
> Priority: Minor
> Attachments: HBASE_11354.patch
>
>
> The method "createAndStart" in class DelayedClosing only creates a instance,
> but forgets to start it. So thread delayedClosing is not running all the time.
> ConnectionManager#1623
> {code}
> static DelayedClosing createAndStart(HConnectionImplementation hci){
> Stoppable stoppable = new Stoppable() {
> private volatile boolean isStopped = false;
> @Override public void stop(String why) { isStopped = true;}
> @Override public boolean isStopped() {return isStopped;}
> };
> return new DelayedClosing(hci, stoppable);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
