[
https://issues.apache.org/jira/browse/HBASE-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042450#comment-14042450
]
stack commented on HBASE-11370:
-------------------------------
nit: Is the javadoc right still?
- * @return map of servers not online to their assigned regions, as stored
- * in META
+ * @return set of servers not online, as stored in META
We are not looking at META anymore?
Why remove the methods in MasterFileSystem? They are not used anymore?
What is lastHost?
- public synchronized RegionState createRegionState(
- final HRegionInfo hri, State newState, ServerName serverName) {
+ public synchronized RegionState createRegionState(final HRegionInfo hri,
+ State newState, ServerName serverName, ServerName lastHost) {
You add to a public method but don't update javadoc.... maybe there is none on
this method?
Oh, looks like it is the server the region was last reported to be up on. That
comes from in-memory state?
And the new splitrRegion and mergeRegion methods are related to this patch?
They were moved?
Why we need to do this in TestHBCK now?
+ // Remove daughters from regionStates
Is it a test problem or new state or a state we always had but you figured it
exists?
lgtm Jimmy. Yeah, be great if mighty [~jeffreyz] had a looksee
> SSH doesn't need to scan meta if not using ZK for assignment
> ------------------------------------------------------------
>
> Key: HBASE-11370
> URL: https://issues.apache.org/jira/browse/HBASE-11370
> Project: HBase
> Issue Type: Improvement
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: hbase-11370.patch
>
>
> If we don't use ZK for assignment, the meta content should be the same as
> that in memory. So we should be able to avoid a meta scan.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
