[ 
https://issues.apache.org/jira/browse/HBASE-11088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043017#comment-14043017
 ] 

ramkrishna.s.vasudevan commented on HBASE-11088:
------------------------------------------------

The reason for adding new commands is that previously deletes were not 
supporting all flavours in the shell
{code}
    
#----------------------------------------------------------------------------------------------
    # Delete a cell
    def _delete_internal(row, column, timestamp = 
org.apache.hadoop.hbase.HConstants::LATEST_TIMESTAMP)
      _deleteall_internal(row, column, timestamp)
    end

    
#----------------------------------------------------------------------------------------------
    # Delete a row
    def _deleteall_internal(row, column = nil, timestamp = 
org.apache.hadoop.hbase.HConstants::LATEST_TIMESTAMP)
      raise ArgumentError, "Row Not Found" if _get_internal(row).nil?
      d = org.apache.hadoop.hbase.client.Delete.new(row.to_s.to_java_bytes, 
timestamp)
      if column
        family, qualifier = parse_column_name(column)
        d.deleteColumns(family, qualifier, timestamp)
      end
      @table.delete(d)
    end
{code}
So it was always calling deleteColumns.  Hence I thought extending this would 
support all types of deletes.  And mainly very helpful in testing these delete 
changes with vis tags.

> Support Visibility Expression Deletes in Shell
> ----------------------------------------------
>
>                 Key: HBASE-11088
>                 URL: https://issues.apache.org/jira/browse/HBASE-11088
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 0.99.0, 0.98.4
>
>         Attachments: HBASE-11058.patch, HBASE-11058_2.patch, 
> HBASE-11088_3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to