[jira] [Resolved] (HBASE-4211) Do init-sizing of the StringBuilder making a ServerName.

[stack (JIRA)]

     [ 
https://issues.apache.org/jira/browse/HBASE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack resolved HBASE-4211.
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.92.0
         Assignee: Benoit Sigoure
     Hadoop Flags: [Reviewed]

Did this remove of synchronized also reported by B while I was at it this 
commit:

{code}
 .../java/org/apache/hadoop/hbase/ServerName.java   |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/main/java/org/apache/hadoop/hbase/ServerName.java 
b/src/main/java/org/apache/hadoop/hbase/ServerName.java
index 6b03832..4ddb5b7 100644
--- a/src/main/java/org/apache/hadoop/hbase/ServerName.java
+++ b/src/main/java/org/apache/hadoop/hbase/ServerName.java
@@ -128,7 +128,8 @@ public class ServerName implements Comparable<ServerName> {
   * startcode formatted as <code>&lt;hostname> ',' &lt;port> ',' 
&lt;startcode></code>
   */
  public static String getServerName(String hostName, int port, long startcode) 
{
-    StringBuilder name = new StringBuilder(hostName);
+    final StringBuilder name = new StringBuilder(hostName.length() + 1 + 5 + 1 
+ 13);
+    name.append(hostName);
    name.append(SERVERNAME_SEPARATOR);
    name.append(port);
    name.append(SERVERNAME_SEPARATOR);
{code}

> Do init-sizing of the StringBuilder making a ServerName.
> --------------------------------------------------------
>
>                 Key: HBASE-4211
>                 URL: https://issues.apache.org/jira/browse/HBASE-4211
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Benoit Sigoure
>            Priority: Minor
>             Fix For: 0.92.0
>
>
> Simple patch from Benoît.
> ---
>  .../java/org/apache/hadoop/hbase/ServerName.java   |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> diff --git a/src/main/java/org/apache/hadoop/hbase/ServerName.java 
> b/src/main/java/org/apache/hadoop/hbase/ServerName.java
> index 6b03832..4ddb5b7 100644
> --- a/src/main/java/org/apache/hadoop/hbase/ServerName.java
> +++ b/src/main/java/org/apache/hadoop/hbase/ServerName.java
> @@ -128,7 +128,8 @@ public class ServerName implements Comparable<ServerName> 
> {
>    * startcode formatted as <code>&lt;hostname> ',' &lt;port> ',' 
> &lt;startcode></code>
>    */
>   public static String getServerName(String hostName, int port, long 
> startcode) {
> -    StringBuilder name = new StringBuilder(hostName);
> +    final StringBuilder name = new StringBuilder(hostName.length() + 1 + 5 + 
> 1 + 13);
> +    name.append(hostName);
>     name.append(SERVERNAME_SEPARATOR);
>     name.append(port);
>     name.append(SERVERNAME_SEPARATOR);
> --
> 1.7.6.434.g1d2b3

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira