[
https://issues.apache.org/jira/browse/HBASE-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049406#comment-14049406
]
Hadoop QA commented on HBASE-11434:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12653463/HBASE-11434.patch
against trunk revision .
ATTACHMENT ID: 12653463
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 13 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
org.apache.hadoop.hbase.replication.TestMasterReplication
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.client.TestReplicaWithCluster.testChangeTable(TestReplicaWithCluster.java:217)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9927//console
This message is automatically generated.
> [AccessController] Disallow inbound cells with reserved tags
> ------------------------------------------------------------
>
> Key: HBASE-11434
> URL: https://issues.apache.org/jira/browse/HBASE-11434
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.99.0, 1.0.0, 0.98.4
>
> Attachments: HBASE-11434.patch, HBASE-11434.patch, HBASE-11434.patch,
> HBASE-11434.patch
>
>
> The AccessController allows users to store cells with ACL tags encoded by the
> client. This isn't a security issue currently, because in order to store the
> cell the user must have a relevant WRITE grant, and the user is allowed to
> specify whatever ACL for the cell they'd like. However it could become a
> correctness problem in the future, if we introduce format sanity checking or
> the like, so let's disallow inbound mutations containing cells with reserved
> tags like the VisibilityController does.
> The check is skipped if the active user is a superuser. First, superusers are
> allowed to do anything. Second, replication (as superuser) must be able to
> store incoming cells with ACL tags.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
