[
https://issues.apache.org/jira/browse/HBASE-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-10885:
-------------------------------------------
Attachment: HBASE-10885_v17.patch
Latest patch addressing all the comments. Added new test case for the ImportTSV
case so that after loading thro MR we can verify the deletes also. This is what
I will be committing.
In the previous QA run it shows 13 find bugs. I am not able to see that link.
I ran mvn package findbugs:findbugs and saw the XML but inferring from them is
bit difficult becuase it shows line that was not added by this patch also. For
eg,
{code}
instanceOccurrenceNum='0' priority='2' abbrev='IS' type='IS2_INCONSISTENT_SYNC'
instanceOccurrenceMax='0'><ShortMessage>Inconsistent
synchronization</ShortMessage><LongMessage>Inconsistent synchronization of
org.apache.hadoop.hbase.security.visibility.VisibilityController.regionEnv;
locked 62% of time</LongMessage><Class
classname='org.apache.hadoop.hbase.security.visibility.VisibilityController'
primary='true'><SourceLine start='132'
classname='org.apache.hadoop.hbase.security.visibility.VisibilityController'
sourcepath='org/apache/hadoop/hbase/security/visibility/VisibilityController.java'
sourcefile='VisibilityController.java' end='1501'><Message>At
VisibilityController.java:[lines 132-1501]</Message></SourceLine><Message>In
class
org.apache.hadoop.hbase.security.visibility.VisibilityController</Message></Class><Field
isStatic='false'
classname='org.apache.hadoop.hbase.security.visibility.VisibilityController'
name='regionEnv' primary='true'
signature='Lorg/apache/hadoop/hbase/coprocessor/RegionCoprocessorEnvironment;'><SourceLine
classname='org.apache.hadoop.hbase.security.visibility.VisibilityController'
sourcepath='org/apache/hadoop/hbase/security/visibility/VisibilityController.java'
sourcefile='VisibilityController.java'><Message>In
VisibilityController.java</Message></SourceLine><Message>Field
org.apache.hadoop.hbase.security.visibility.VisibilityController.regionEnv</Message></Field><Int
value='62' role='INT_SYNC_PERCENT'><Message>Synchronized 62% of the
time</Message></Int><SourceLine endBytecode='9' startBytecode='9' start='1320'
classname='org.apache.hadoop.hbase.security.visibility.VisibilityController'
primary='true'
sourcepath='org/apache/hadoop/hbase/security/visibility/VisibilityController.java'
role='SOURCE_LINE_UNSYNC_ACCESS' sourcefile='VisibilityController.java'
end='1320'><Message>Unsynchronized access at VisibilityController.java:[line
1320]</Message></SourceLine><SourceLine endBytecode='72' startBytecode='72'
start='192'
classname='org.apache.hadoop.hbase.security.visibility.VisibilityController'
sourcepath='org/apache/hadoop/hbase/security/visibility/VisibilityController.java'
role='SOURCE_LINE_UNSYNC_ACCESS' sourcefile='VisibilityController.java'
end='192'>
{code}
So if there any any real find bug issue will fix it as a followup?
> Support visibility expressions on Deletes
> -----------------------------------------
>
> Key: HBASE-10885
> URL: https://issues.apache.org/jira/browse/HBASE-10885
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.98.1
> Reporter: Andrew Purtell
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.99.0, 1.0.0, 0.98.4
>
> Attachments:
> 10885-org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes-output.txt,
> HBASE-10885_1.patch, HBASE-10885_2.patch, HBASE-10885_new_tag_type_1.patch,
> HBASE-10885_new_tag_type_2.patch, HBASE-10885_v1.patch,
> HBASE-10885_v12.patch, HBASE-10885_v12.patch, HBASE-10885_v13.patch,
> HBASE-10885_v15.patch, HBASE-10885_v17.patch, HBASE-10885_v2.patch,
> HBASE-10885_v2.patch, HBASE-10885_v2.patch, HBASE-10885_v3.patch,
> HBASE-10885_v4.patch, HBASE-10885_v5.patch, HBASE-10885_v7.patch,
> HBASE-10885_v8.patch, HBASE-10885_v9.patch
>
>
> Accumulo can specify visibility expressions for delete markers. During
> compaction the cells covered by the tombstone are determined in part by
> matching the visibility expression. This is useful for the use case of data
> set coalescing, where entries from multiple data sets carrying different
> labels are combined into one common large table. Later, a subset of entries
> can be conveniently removed using visibility expressions.
> Currently doing the same in HBase would only be possible with a custom
> coprocessor. Otherwise, a Delete will affect all cells covered by the
> tombstone regardless of any visibility expression scoping. This is correct
> behavior in that no data spill is possible, but certainly could be
> surprising, and is only meant to be transitional. We decided not to support
> visibility expressions on Deletes to control the complexity of the initial
> implementation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
