[ 
https://issues.apache.org/jira/browse/HBASE-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055341#comment-14055341
 ] 

Gary Helmling commented on HBASE-11444:
---------------------------------------

Did you intend to remove the caching of the previously resolved short name as 
well?
{noformat}
-      if (shortName != null) return shortName;
{noformat}

This was there because the UserGroupInformation implementation of it, which 
iterates the Subject's principals to return it, had shown up as having a 
surprisingly measurable impact in profiling of AccessController.

> Remove use of reflection for User#getShortName
> ----------------------------------------------
>
>                 Key: HBASE-11444
>                 URL: https://issues.apache.org/jira/browse/HBASE-11444
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.98.3
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.98.4
>
>         Attachments: HBASE-11444.patch, IntegrationTestIngestWithACL.get.svg, 
> IntegrationTestIngestWithACL.put.svg
>
>
> The time we spend looking up a user's short name with User#getShortName in 
> hot security code paths is mostly spent in Class#getMethod, ~70%. This is 
> only ~1% of overall CPU time but is the bulk of time spent in 
> AccessController#prePut, for example.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to