[ https://issues.apache.org/jira/browse/HBASE-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057749#comment-14057749 ]
Hadoop QA commented on HBASE-11437: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655041/HBASE-11437_trunk.patch against trunk revision . ATTACHMENT ID: 12655041 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 21 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10020//console This message is automatically generated. > Modify cell tag handling code to treat the length as unsigned > ------------------------------------------------------------- > > Key: HBASE-11437 > URL: https://issues.apache.org/jira/browse/HBASE-11437 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.98.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11437.patch, HBASE-11437.patch, HBASE-11437.patch, > HBASE-11437_trunk.patch > > > We store each tag's length and total tags length with 2 bytes in KeyValue > buffer, HFiles etc and we treat these lengths as short through out the code. > So the max length can be Short.MAX_VALUE. We can treat these lengths as > unsigned and +ve always. So we can actually treat these lengths as int and > store with 2 bytes so that the max length can reach 65535. -- This message was sent by Atlassian JIRA (v6.2#6252)