[
https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057962#comment-14057962
]
Hadoop QA commented on HBASE-11499:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655074/HBASE-11499.patch.txt
against trunk revision .
ATTACHMENT ID: 12655074
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10023//console
This message is automatically generated.
> AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
> -----------------------------------------------------------------------------
>
> Key: HBASE-11499
> URL: https://issues.apache.org/jira/browse/HBASE-11499
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Mike Drob
> Priority: Trivial
> Labels: findbugs
> Attachments: HBASE-11499.patch.txt
>
>
> The method is building a string using lots of concatenation, including in a
> loop, which will be {{O(n^2)}} because a new array will be allocated each
> time. Would be more efficient to use a StringBuilder for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
