[ 
https://issues.apache.org/jira/browse/HBASE-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058212#comment-14058212
 ] 

Virag Kothari commented on HBASE-11501:
---------------------------------------

Without the fix, the JmxCacheBusterRunnable is never called and metrics are not 
removed from cache. With the fix, the metrics will be removed as the runnable 
will run and will stop the metrics system 
(DefaultMetricsSystem.instance().stop()). However when it tries to start the 
metrics system ( DefaultMetricsSystem.instance().start()), it cant register the 
mbeans with the same name as before due to Hadoop-9559. This will cause the 
metrics system to even stop publishing metrics.
So, running on hadoop 2.4 with this fix will do more harm than good. So either 
it should go with hadoop 2.5 or if Hadoop-9559 is backported to 2.4 (and other 
versions if required), then I believe this patch can go in before.


> Metrics from JMX cache are not cleared
> --------------------------------------
>
>                 Key: HBASE-11501
>                 URL: https://issues.apache.org/jira/browse/HBASE-11501
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.98.3
>            Reporter: Virag Kothari
>            Assignee: Virag Kothari
>         Attachments: HBASE-11501.patch, HBASE-11501.patch
>
>
> In JmxCacheBuster, clearJmxCache() has incorrect condition for starting 
> JmxCacheBusterRunnable



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to