[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087012#comment-13087012
]
Ted Yu commented on HBASE-4213:
-------------------------------
I wonder if the following check is accurate because servers and rsCount are
both returned from ZKUtil methods:
{code}
+ int rsCount = ZKUtil.getNumberOfChildren(this.watcher, path);
+ if (servers != null && servers.size() >= rsCount) {
{code}
In TestInstantSchemaChange:
{code}
miniHBaseCluster = TEST_UTIL.startMiniCluster(3);
{code}
I added rsCount in your log statement.
Then I saw the following in
org.apache.hadoop.hbase.client.TestInstantSchemaChange-output.txt:
{code}
tyumac:trunk tyu$ grep ' region servers have successfully '
target/surefire-reports/org.apache.hadoop.hbase.client.TestInstantSchemaChange-output.txt
2011-08-17 21:54:54,995 DEBUG [main-EventThread]
zookeeper.MasterSchemaChangeTracker(69): All 2 region servers have successfully
processed the schema changes for table = testSchemachange . Deleting the schema
change node = /hbase/schema/testSchemachange
2011-08-17 21:54:57,459 DEBUG [main-EventThread]
zookeeper.MasterSchemaChangeTracker(69): All 2 region servers have successfully
processed the schema changes for table = testSchemachangeForAddColumn .
Deleting the schema change node = /hbase/schema/testSchemachangeForAddColumn
2011-08-17 21:54:58,120 DEBUG [main-EventThread]
zookeeper.MasterSchemaChangeTracker(69): All 2 region servers have successfully
processed the schema changes for table = testSchemachangeForModifyColumn .
Deleting the schema change node = /hbase/schema/testSchemachangeForModifyColumn
2011-08-17 21:54:58,330 DEBUG [main-EventThread]
zookeeper.MasterSchemaChangeTracker(69): All 3 region servers have successfully
processed the schema changes for table = testSchemachangeNode . Deleting the
schema change node = /hbase/schema/testSchemachangeNode
{code}
Looks like master might delete schema change node prematurely.
> Support instant schema updates with out master's intervention (i.e with out
> enable/disable and bulk assign/unassign)
> --------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4213
> URL: https://issues.apache.org/jira/browse/HBASE-4213
> Project: HBase
> Issue Type: Improvement
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Fix For: 0.92.0
>
> Attachments: HBASE-4213-Instant_schema_change.patch
>
>
> This Jira is a slight variation in approach to what is being done as part of
> https://issues.apache.org/jira/browse/HBASE-1730
> Support instant schema updates such as Modify Table, Add Column, Modify
> Column operations:
> 1. With out enable/disabling the table.
> 2. With out bulk unassign/assign of regions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
