[
https://issues.apache.org/jira/browse/HBASE-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060064#comment-14060064
]
Hudson commented on HBASE-11437:
--------------------------------
FAILURE: Integrated in HBase-0.98 #391 (See
[https://builds.apache.org/job/HBase-0.98/391/])
HBASE-11437 Modify cell tag handling code to treat the length as unsigned.
(Anoop) (anoopsamjohn: rev f2d16e0a8cf6fc349216ffcc9c2b6eabd3a99c0d)
*
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV3.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
*
hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java
*
hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecWithTags.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
* hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/DataBlockEncodingTool.java
*
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
*
hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/KeyValueCompression.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationWithTags.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java
*
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
*
hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestPayloadCarryingRpcController.java
*
hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestKeyValueCodecWithTags.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java
*
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecWithTags.java
*
hbase-common/src/main/java/org/apache/hadoop/hbase/io/TagCompressionContext.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java
*
hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestTagCompressionContext.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV3.java
> Modify cell tag handling code to treat the length as unsigned
> -------------------------------------------------------------
>
> Key: HBASE-11437
> URL: https://issues.apache.org/jira/browse/HBASE-11437
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.98.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.99.0, 0.98.4, 2.0.0
>
> Attachments: HBASE-11437.patch, HBASE-11437.patch, HBASE-11437.patch,
> HBASE-11437_0.98.patch, HBASE-11437_0.98_V2.patch, HBASE-11437_trunk.patch
>
>
> We store each tag's length and total tags length with 2 bytes in KeyValue
> buffer, HFiles etc and we treat these lengths as short through out the code.
> So the max length can be Short.MAX_VALUE. We can treat these lengths as
> unsigned and +ve always. So we can actually treat these lengths as int and
> store with 2 bytes so that the max length can reach 65535.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
