[ 
https://issues.apache.org/jira/browse/HBASE-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060218#comment-14060218
 ] 

stack commented on HBASE-11507:
-------------------------------

[~gustavoanatoly] Anything that helps with the hbase 1.0 project would be 
appreciated.  See HBASE-10856 for its list of items to do and linked issues.  
If that list has nought of interest just say and can dig up something else.  
Write me offline if you'd like input or help, np.


bq. What a weird issue....

'weird' is wrong in above.  The patch attached could be of some, rare 'utility'.

Grepping 'HBaseZeroCopyByteString\.wrap()' seems wrong though given the wrap 
takes args.... and there is also zeroCopyGetBytes....

I'd think we'd at least start by adding warning javadoc on the objectional 
class itself discouraging its use with why....

If out to build yourself a track record [~gustavoanatoly], yeah, take on 
something more substantial.  Good on you.


> Enhance test-patch.sh to check for direct calls to 
> HBaseZeroCopyByteString.wrap()
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-11507
>                 URL: https://issues.apache.org/jira/browse/HBASE-11507
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Gustavo Anatoly
>            Priority: Trivial
>         Attachments: HBASE-11507.patch
>
>
> HBaseZeroCopyByteString.wrap() should not be called directly.
> ByteStringer.wrap() should be called instead.
> This task adds check for direct calls to HBaseZeroCopyByteString.wrap() to 
> test-patch.sh.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to