[
https://issues.apache.org/jira/browse/HBASE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087233#comment-13087233
]
[email protected] commented on HBASE-4027:
------------------------------------------------------
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/Cacheable.java, line 12
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32972#file32972line12>
bq. >
bq. > Please add javadoc for these methods.
Done.
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java,
line 92
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32974#file32974line92>
bq. >
bq. > This shows that Cacheable can reside in on-heap cache.
bq. > The description for Cacheable should be refined.
Done. Cacheable can reside in either.
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 79
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32975#file32975line79>
bq. >
bq. > HeapSize is covered by Cacheable so is not needed here.
Done.
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 1528
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32975#file32975line1528>
bq. >
bq. > Indentation is incorrect here.
Done.
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 1535
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32975#file32975line1535>
bq. >
bq. > Since HFileBlock implements Cacheable, people may get confused by
what 'selfWithoutByteBuffer' means.
bq. > Please add javadoc.
Done.
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 1540
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32975#file32975line1540>
bq. >
bq. > Please add javadoc for what this method does.
Done.
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 1541
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32975#file32975line1541>
bq. >
bq. > Whitespace.
Done.
bq. On 2011-08-17 04:44:54, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java, line 1554
bq. > <https://reviews.apache.org/r/1214/diff/13/?file=32975#file32975line1554>
bq. >
bq. > Indentation.
Done.
- Li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1214/#review1489
-----------------------------------------------------------
On 2011-08-18 08:31:59, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1214/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-18 08:31:59)
bq.
bq.
bq. Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, Jonathan
Gray, and Li Pi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review request - I apparently can't edit tlipcon's earlier posting of my
diff, so creating a new one.
bq.
bq.
bq. This addresses bug HBase-4027.
bq. https://issues.apache.org/jira/browse/HBase-4027
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. conf/hbase-env.sh 2d55d27
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 2d4002c
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/Cacheable.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java 3b130d8
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java 097dc50
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
1338453
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java
886c31d
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/Slab.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
PRE-CREATION
bq.
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
e2c6c93
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
7b7bf73
bq. src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java
1ad2ece
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java
f0a9832
bq.
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlab.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreLAB.java
d7e43a0
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
4387170
bq.
bq. Diff: https://reviews.apache.org/r/1214/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran benchmarks against it in HBase standalone mode. Wrote test cases for
all classes, multithreaded test cases exist for the cache.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Enable direct byte buffers LruBlockCache
> ----------------------------------------
>
> Key: HBASE-4027
> URL: https://issues.apache.org/jira/browse/HBASE-4027
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Assignee: Li Pi
> Priority: Minor
> Attachments: 4027-v5.diff, 4027v7.diff, HBase-4027 (1).pdf,
> HBase-4027.pdf, HBase4027v8.diff, HBase4027v9.diff, hbase-4027-v10.5.diff,
> hbase-4027-v10.diff, hbase-4027v10.6.diff, hbase-4027v6.diff,
> hbase4027v11.5.diff, hbase4027v11.6.diff, hbase4027v11.7.diff,
> hbase4027v11.diff, hbase4027v12.1.diff, hbase4027v12.diff,
> slabcachepatch.diff, slabcachepatchv2.diff, slabcachepatchv3.1.diff,
> slabcachepatchv3.2.diff, slabcachepatchv3.diff, slabcachepatchv4.5.diff,
> slabcachepatchv4.diff
>
>
> Java offers the creation of direct byte buffers which are allocated outside
> of the heap.
> They need to be manually free'd, which can be accomplished using an
> documented {{clean}} method.
> The feature will be optional. After implementing, we can benchmark for
> differences in speed and garbage collection observances.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
